Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix select bind:value when option value change #4885

Merged
merged 2 commits into from
May 21, 2020
Merged

fix select bind:value when option value change #4885

merged 2 commits into from
May 21, 2020

Conversation

tanhauhau
Copy link
Member

Fixes: #1764

reselect <select> when option value changed.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Conduitry Conduitry merged commit e34f208 into sveltejs:master May 21, 2020
@tanhauhau tanhauhau deleted the tanhauhau/fix-select-bind-value-when-option-changed branch May 22, 2020 00:52
@Conduitry Conduitry mentioned this pull request Jun 22, 2020
Closed
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
reselect <select> when the option values change (sveltejs#4885)
e503602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bind:value for keyed select tag doesn't work when options are updated
2 participants
@tanhauhau @Conduitry